PR Checks: Test codeql-bundle.tar.gz#1822
Conversation
angelapwen
force-pushed
the
test-codeql-bundle-all
branch
3 times, most recently
from
ec8eb0f to
7420f88
Compare
angelapwen
force-pushed
the
test-codeql-bundle-all
branch
from
7420f88 to
3636aac
Compare
angelapwen
changed the title
codeql-bundle-allcodeql-bundle.tar.gz
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments.
| version: | ||
| description: "The version of the CodeQL CLI to use. Can be 'latest', 'default', 'nightly-latest', 'nightly-YYYY-MM-DD', or 'stable-YYYY-MM-DD'." | ||
| required: true | ||
| require-codeql-bundle-all: |
There was a problem hiding this comment.
Minor: How about use-all-platform-bundle, to make it more clear what the "all" means?
| @@ -0,0 +1,56 @@ | |||
| name: 'PR Check - CodeQL Bundle All' | |||
There was a problem hiding this comment.
Optional: We could consider autogenerating this by adding a top-level property to the workflow specifications and forwarding this to prepare-test
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| version: nightly-latest |
There was a problem hiding this comment.
Perhaps matrix over default, latest, nightly-latest to test the three most relevant bundles.
There was a problem hiding this comment.
Hm... using default or latest doesn't specify the bundle artifact to download in the prepare-test action: https://github.com/github/codeql-action/blob/main/.github/actions/prepare-test/action.yml#L47-L50 🤔
There was a problem hiding this comment.
Oh, I see, since the Action determines the artifact name in these cases. In which case, I think testing the nightly is good enough.
2 participants
This PR check makes sure that we are testing the case where we use the non-platform specific
codeql-bundle.tar.gzfile for analysis. To do so, we've added ause-all-platform-bundleinput to theprepare-testaction that we set to true in the new PR check.Merge / deployment checklist